Add parallel text execution #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes TSan and UBSan locally, by the way. I found a bug in ShellOut through TSan and fixed it on a fork, so we're using that as the dependency until my PR gets accepted. Tests pass locally -- |
harlanhaskins
force-pushed
the
parallelism-yeah-yeah
branch
from
7f188b0 to
a58d229
Compare
harlanhaskins
force-pushed
the
parallelism-yeah-yeah
branch
from
a58d229 to
4cc6233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This test enables parallel execution of tests, to significantly speed up total testing time for long-running tests.
Why merge this pull request?
For the Trill test suite, it cuts the time it takes to run the test suite by a huge margin. I figured parallelism was the next step for this, as it becomes very important as a large number of tests are added.
What's worth discussing about this pull request?
The general algorithm for splitting execution of tests among workers, the switch to ShellOut instead of SwiftShell
What downsides are there to merging this pull request?
Test results are no longer in sorted order when parallelism is enabled.